Skip to content

[CI/Build] Fix param mismatch in test_eagle_correctness #22847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

[CI/Build] Fix param mismatch in test_eagle_correctness #22847

merged 1 commit into from
Aug 13, 2025

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Aug 13, 2025 •
edited by github-actions bot
Loading

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

#22611 forgot to remove the corresponding param inside ids.

I'll force-merge this once approved since I can run these tests locally now

Test Plan

Test Result

(Optional) Documentation Update

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Aug 13, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 13, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a parameter mismatch in the test_eagle_correctness test. A previous change had commented out a test case parameter but neglected to remove its corresponding ID, leading to a test failure. This PR resolves the issue by commenting out the associated test ID, ensuring the test configuration is valid. The change is straightforward and correct.

22quinn
22quinn approved these changes Aug 13, 2025
View reviewed changes
Copy link
Collaborator

@22quinn 22quinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@vllm-bot vllm-bot merged commit b4b78d6 into vllm-project:main Aug 13, 2025
8 of 13 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-spec-decode-test branch August 13, 2025 17:55
@DarkLight1337
Copy link
Member Author

OK I found a failure in tests/v1/e2e/test_spec_decode.py::test_eagle_correctness[TREE_ATTN-llama3_eagle]

AssertionError: assert 66 > 66

@DarkLight1337
Copy link
Member Author

cc @TheEpicDolphin

@22quinn 22quinn mentioned this pull request Aug 13, 2025
Closed
4 tasks
taneem-ibrahim pushed a commit to taneem-ibrahim/vllm that referenced this pull request Aug 14, 2025
@DarkLight1337 @taneem-ibrahim
[CI/Build] Fix param mismatch in test_eagle_correctness (vllm-proje…
b3cb34a 
…ct#22847)

Signed-off-by: DarkLight1337 <[email protected]>
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Aug 14, 2025
@DarkLight1337 @BoyuanFeng
[CI/Build] Fix param mismatch in test_eagle_correctness (vllm-proje…
98e1697 
…ct#22847)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Boyuan Feng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Isotr0py Isotr0py Isotr0py approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@22quinn 22quinn 22quinn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DarkLight1337 @22quinn @Isotr0py @vllm-bot